Repository navigation
Add VS Code keymap profile - #9672
ashwintemkar wants to merge 1 commit into
Conversation
|
@ashwintemkar @king-407 we now have two draft PRs for VS code keymap. Could you please cross check and see if one of these can be closed and move improvements that are missing to the retained one? Duplicate/other PR: #9608 |
|
Hi @matthiasblaesing @king-407, Thanks for flagging this. A bit of history on my side: I opened two earlier draft PRs for this issue (#7682 and #8200). The first one didn't quite get the mappings right, and the second got further but @mbien found a couple of real bugs in review (wrong bundle reference, an invalid keystroke) that I never got back to fixing before things went quiet on my end. I got back to notice while developing and contributing elsewhere for hacktoberfest this year and went through @mbien review comments properly this time, and fixed the underlying issues. Since the old PRs can't be reopened anymore, #9672 is that work landing as a fresh PR. @king-407, I don't know if this is your first contribution here, so I don't want to step on it if you'd rather carry this one forward. Happy to close #9672 and help port anything useful across if so. Otherwise I'm happy to keep going on #9672 and pull in anything from #9608 that's missing. Let me know what works for you and I'll follow your lead. |
|
Thanks for the context. Since #9608 is already open for #6458, I would be happy to continue with it as the base PR and incorporate any useful fixes from #9672, especially the earlier review feedback around invalid shortcut/action mappings and bundle registration. I do not want to create duplicate review work, so I can compare both PRs and update #9608 with the missing pieces. Once the useful parts are consolidated into one PR, we can close the duplicate and keep the review focused. @ashwintemkar, if that works for you, I’m happy to credit your findings from the earlier attempts while porting the improvements. |
|
Closing in favor of #9608, consolidating review there per the discussion above. |
Description:
This is a pull request to facilitate the migration of keybindings from VSCode to NetBeans, aiming to ensure a smooth transition for users without altering their familiar keybinding setup.
Fixes the Issue
Add a keymap for VS Code #6458
Changes:
Current Status:
All global and editor shortcuts now point at real, existing NetBeans actions, checked against the Idea and Eclipse keymap profiles already in the codebase, and against VS Code's own keyboard shortcut reference sheets for both Windows and Mac.
Objective:
Enable users migrating from VSCode to NetBeans to retain their existing keybindings and workflows effectively.
By opening this pull request you confirm that, unless explicitly stated otherwise:
Yes
Yes
PR approval and merge checklist: