Skip to content

Add VS Code keymap profile - #9672

Closed
ashwintemkar wants to merge 1 commit into
apache:masterfrom
ashwintemkar:vscodekeymap
Closed

ashwintemkar wants to merge 1 commit into
apache:masterfrom
ashwintemkar:vscodekeymap

Conversation

@ashwintemkar

@ashwintemkar ashwintemkar commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Description:
This is a pull request to facilitate the migration of keybindings from VSCode to NetBeans, aiming to ensure a smooth transition for users without altering their familiar keybinding setup.

Fixes the Issue
Add a keymap for VS Code #6458

Changes:

  • I Mapped VSCode Keybindings: Replaced the keybinding file names and actions from VSCode with their corresponding NetBeans equivalents.
  • Then I Fixed the root cause from the earlier PR (Added a keymap for VS Code #7682, Added Support for VScode keymap in Netbeans IDE for windows and mac #6458 #8200): the global shortcuts in mf-layer.xml were pointing to actions that don't exist (org.vscode.core.actions.*), and the bundle reference was wrong. That was causing every shortcut in the profile to log as an "Invalid shortcut" warning, not just the couple mbien flagged on review.
  • Preserved Functionality: Maintained the original functionality of keybindings to provide a seamless transition.

Current Status:
All global and editor shortcuts now point at real, existing NetBeans actions, checked against the Idea and Eclipse keymap profiles already in the codebase, and against VS Code's own keyboard shortcut reference sheets for both Windows and Mac.

Objective:
Enable users migrating from VSCode to NetBeans to retain their existing keybindings and workflows effectively.

By opening this pull request you confirm that, unless explicitly stated otherwise:

  • The changes are all your own work, and you have the right to contribute them.
    Yes
  • The contributions are made solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
    Yes

PR approval and merge checklist:

  • Was this PR correctly labeled, did the right tests run? When did they run?
  • Is this PR squashed?
  • Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  • Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

@matthiasblaesing

matthiasblaesing commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

@ashwintemkar @king-407 we now have two draft PRs for VS code keymap. Could you please cross check and see if one of these can be closed and move improvements that are missing to the retained one?

Duplicate/other PR: #9608

@ashwintemkar

ashwintemkar commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor Author

Hi @matthiasblaesing @king-407,

Thanks for flagging this. A bit of history on my side: I opened two earlier draft PRs for this issue (#7682 and #8200). The first one didn't quite get the mappings right, and the second got further but @mbien found a couple of real bugs in review (wrong bundle reference, an invalid keystroke) that I never got back to fixing before things went quiet on my end.

I got back to notice while developing and contributing elsewhere for hacktoberfest this year and went through @mbien review comments properly this time, and fixed the underlying issues. Since the old PRs can't be reopened anymore, #9672 is that work landing as a fresh PR.

@king-407, I don't know if this is your first contribution here, so I don't want to step on it if you'd rather carry this one forward. Happy to close #9672 and help port anything useful across if so. Otherwise I'm happy to keep going on #9672 and pull in anything from #9608 that's missing. Let me know what works for you and I'll follow your lead.

@king-407

king-407 commented Oct 6, 2026

Copy link
Copy Markdown

Thanks for the context.

Since #9608 is already open for #6458, I would be happy to continue with it as the base PR and incorporate any useful fixes from #9672, especially the earlier review feedback around invalid shortcut/action mappings and bundle registration.

I do not want to create duplicate review work, so I can compare both PRs and update #9608 with the missing pieces. Once the useful parts are consolidated into one PR, we can close the duplicate and keep the review focused.

@ashwintemkar, if that works for you, I’m happy to credit your findings from the earlier attempts while porting the improvements.

@ashwintemkar

Copy link
Copy Markdown
Contributor Author

Sounds good, thanks @king-407. Closing #9672 now and leaving the specific gaps I found on #9608 so you can pull in whatever's useful. No need to credit anything individually, happy to just have this land in one clean PR.

@ashwintemkar

Copy link
Copy Markdown
Contributor Author

Closing in favor of #9608, consolidating review there per the discussion above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants