Repository navigation
wasm2js: Support elem.drop - #9224
Merged
Merged
Conversation
In wasm2js, element segments are statically initialized into FUNCTION_TABLE at module startup, and table.init is not supported, so elem.drop has no observable effect and can be treated as a no-op.
Member
|
Is there a reason to support this? In general we have not been adding new feature support to wasm2js. |
Member
Author
|
#9201 makes the fuzzer emit |
kripken
approved these changes
Oct 7, 2026
kripken
left a comment
Member
There was a problem hiding this comment.
I see, thanks, sgtm as a simple fuzzer workaround.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In wasm2js, element segments are statically initialized into
FUNCTION_TABLE at module startup, and table.init is not supported,
so elem.drop has no observable effect and can be treated as a no-op.